Hard code expected labels on obsreport tests #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to prevent inadvertent changes of the labels. Using hard coded values requires manual changes of the tests.
pjanotti
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
rghetia,
songy23 and
tigrannajaryan
as code owners
4 tasks
tigrannajaryan
approved these changes
Jun 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
=======================================
Coverage 86.29% 86.29%
=======================================
Files 200 200
Lines 14166 14166
=======================================
Hits 12225 12225
Misses 1481 1481
Partials 460 460
Continue to review full report at Codecov.
|
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
* Hard code expected labels on obsreport tests The goal is to prevent inadvertent changes of the labels. Using hard coded values requires manual changes of the tests. * Add reason to be careful about metric name and label changes
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
* Update Operator README.md * bump operator chart patch version * generate-examples --------- Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to prevent inadvertent changes of the labels. Using hard coded values requires manual changes of the tests.
Description:
Part of complete the switch to the new metrics, see #1082
Link to tracking Issue: #1082